Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

judge: pass result to checkers #1021

Merged
merged 1 commit into from
Mar 29, 2022
Merged

judge: pass result to checkers #1021

merged 1 commit into from
Mar 29, 2022

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Mar 12, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #1021 (de7a252) into master (9551b06) will decrease coverage by 27.94%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1021       +/-   ##
===========================================
- Coverage   81.24%   53.30%   -27.95%     
===========================================
  Files         140      140               
  Lines        4789     4784        -5     
===========================================
- Hits         3891     2550     -1341     
- Misses        898     2234     +1336     
Impacted Files Coverage Δ
dmoj/graders/standard.py 97.91% <ø> (ø)
dmoj/executors/C.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/D.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/GO.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/ADA.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/AWK.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/C11.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/F95.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/ICK.py 0.00% <0.00%> (-100.00%) ⬇️
dmoj/executors/LUA.py 0.00% <0.00%> (-100.00%) ⬇️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9551b06...de7a252. Read the comment docs.

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to do this, let's just pass the whole result object

@Riolku
Copy link
Contributor Author

Riolku commented Mar 12, 2022

Hm.. but keep the rest of the kwargs for backward compatability?

@Xyene
Copy link
Member

Xyene commented Mar 12, 2022

Yes

@Riolku
Copy link
Contributor Author

Riolku commented Mar 12, 2022

Passing result now, updated tests and commit message.

@Riolku Riolku changed the title judge: pass max_memory to checkers judge: pass result to checkers Mar 12, 2022
@kiritofeng kiritofeng requested a review from Xyene March 23, 2022 16:56
Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Riolku Riolku force-pushed the checker-memory branch 3 times, most recently from 4c865b1 to de7a252 Compare March 29, 2022 00:44
@Riolku
Copy link
Contributor Author

Riolku commented Mar 29, 2022

Seems black is bricked right now. I'll check back later tonight.

Keep all old arguments to `check` for backward compatibility.
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@Xyene Xyene merged commit 98237a2 into DMOJ:master Mar 29, 2022
@Riolku Riolku deleted the checker-memory branch March 31, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants